This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
feat: utils - re-export @polkadot/util as dotUtils #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolad
commented
Apr 7, 2023
core/providers/temp.test.ts
Outdated
| @@ -1,5 +0,0 @@ | |||
| import { assert } from 'https://deno.land/[email protected]/testing/asserts.ts'; | |||
There was a problem hiding this comment.
@DoubleOTheven hope the removal is fine here
nicolad
commented
Apr 7, 2023
core/utils/mod.ts
Outdated
| @@ -3,3 +3,4 @@ export * from './contracts/mod.ts'; | |||
| export * from './getExpiredItem.ts'; | |||
| export * from './parseUnits.ts'; | |||
| export * from './pseudoRandomId.ts'; | |||
| export * from './units/mod.ts'; | |||
There was a problem hiding this comment.
I saw mod.ts approach in a different folder and followed up that.
| @@ -14,7 +14,10 @@ interface RemoveContractEvent { | |||
|
|
|||
| type Action = AddContractEvent | RemoveContractEvent; | |||
|
|
|||
| export function contractEventReducer(state: ContractEvents, action: Action): ContractEvents { | |||
| export function contractEventReducer( | |||
There was a problem hiding this comment.
It looks like there is a lot of formatting. Does your IDE have a different config for max character length, etc?
There was a problem hiding this comment.
it was just deno fmt, should I revert this change?
There was a problem hiding this comment.
reverted the change, if needed or if u want can create a separate PR with deno fmt
nicolad
changed the title
|
I just exported everything using the This is how you set up a new import path. e.g. And I export here |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #29